Silmaril [2665762]

'market' -> 'itemmarket' is returning nulls for listing prices of many items

armor & weapons work OK, but all other items are like this

 

POST https://api.torn.com/v2/market/428?selections=itemMarket

{
    "itemmarket": {
        "item": {
            "id": 428,
            "name": "Casino Pass",
            "type": "Special",
            "average_price": 19811050
        },
        "listings": [
            {
                "id": null,
                "price": null,
                "amount": null
            },
            {
                "id": null,
                "price": null,
                "amount": null
            }
        ]
    },
    "_metadata": {
        "prev": null,
        "next": null
    }
}

splent [2088243]

Hey, that should be fixed now!

Let me know if there's anything else.

Thanks!

splent [2088243]

Hey, that should be fixed now!

Let me know if there's anything else.

Thanks!

Silmaril [2665762]

Again it's broken.

But in other way.

Now it gives you cached version of the previous item u requested, even though u request totally DIFFERENT item.

You probably added caching based on time, but also need to add itemId as another key component.

 

_SCOFIELD_ [1441750]

Seems like if you use

 

"https://api.torn.com/v2/market/?selections=itemmarket&key={key}&id=1118"

 

this format instead of

 

"https://api.torn.com/v2/market/1118?selections=itemmarket&key={key}"

 

then it works fine

splent [2088243]

Hey, that should be fixed now!

Let me know if there's anything else.

Thanks!

Silmaril [2665762]

Again it's broken.

But in other way.

Now it gives you cached version of the previous item u requested, even though u request totally DIFFERENT item.

You probably added caching based on time, but also need to add itemId as another key component.

 

Manuito [2225097]

Unless I'm mistaken, in v2, this three nullables:

 

      "nullable": "true"

 

should be really be

 

       "nullable": true

 

(no commas):

 

 

            "ItemMarketListingItemStats": {
                "properties": {
                    "damage": {
                        "type": "number",
                        "format": "float",
                        "nullable": "true"
                    },
                    "accuracy": {
                        "type": "number",
                        "format": "float",
                        "nullable": "true"
                    },
                    "armor": {
                        "type": "number",
                        "format": "float",
                        "nullable": "true"
                    }
                },
                "type": "object"
            },

 

 

Otherwise it's causing a parsing error when automating the swagger model creation.

splent [2088243]

Thanks - I've fixed these now I think?

If everything goes as planned, this week I should finish v2 upgrade where requests will also work in this format: "/v2/user/crimes/1/" (or "/v2/user/crimes,timestamp/1/" when requesting multiple selections) and all endpoints will have their paths fixed (e.g. from /user/?selection=crimes to /user/crimes/). 

 

Hopefully that will fix all code-gen issues!

splent [2088243]

Hey, that should be fixed now!

Let me know if there's anything else.

Thanks!

Silmaril [2665762]

Again it's broken.

But in other way.

Now it gives you cached version of the previous item u requested, even though u request totally DIFFERENT item.

You probably added caching based on time, but also need to add itemId as another key component.

 

splent [2088243]

Hey everyone!

I'm excited to announce item market API is back. We now have:

• 'user' -> 'itemmarket' which can be accessed with a limited API key or higher. This selection returns only your item market listings
• 'market' -> 'itemmarket' is now back, however in somewhat limited edition. It's possible to go through item market listings for a specific item in this selection and additionally filter weapons by a specific bonus

 

In the upcoming weeks, the plan is to add additional filtering options if everything goes well (price, damage, accuracy, armor) and sorting options (ascending & descending).

You will also notice that currently 'market' -> 'itemmarket' selection does not contain information about the seller. This is partially due to some system limitations I have to deal with first, but also partially because of some concerns with mug bots.

It's still not fully decided if this information will be added or not, so your opinion and feedback is more than welcome here!

Additionally, we'll be retiring 'market' -> 'bazaar' selection in approx. 2 weeks time, as it currently doesn't bring much value.
However, as soon as bazaars are updated or in case they become visible in another part of the system, I'll be more than happy to bring back bazaar API.

Edit: As always, these selection are now also available in Swagger, just make sure to update your cache.

Edit 2: There was a small update on 'torn' -> 'itemstats' selection. It will now return "0" for the "first_owner" field, if the item is listed anonymously on the market.

Thanks!

Glasnost [1844049]

For both API v1 (and when it comes, v2), can we get a field to indicate whether items are locked for purchase in bazaars? The data isn't available and when building market tools, it frustrates people to visit a bazaar only to find the item can't be purchased, and it is locked at the top of a page as the cheapest.

Manuito [2225097]

Unless I'm mistaken, in v2, this three nullables:

 

      "nullable": "true"

 

should be really be

 

       "nullable": true

 

(no commas):

 

 

            "ItemMarketListingItemStats": {
                "properties": {
                    "damage": {
                        "type": "number",
                        "format": "float",
                        "nullable": "true"
                    },
                    "accuracy": {
                        "type": "number",
                        "format": "float",
                        "nullable": "true"
                    },
                    "armor": {
                        "type": "number",
                        "format": "float",
                        "nullable": "true"
                    }
                },
                "type": "object"
            },

 

 

Otherwise it's causing a parsing error when automating the swagger model creation.

splent [2088243]

Thanks - I've fixed these now I think?

If everything goes as planned, this week I should finish v2 upgrade where requests will also work in this format: "/v2/user/crimes/1/" (or "/v2/user/crimes,timestamp/1/" when requesting multiple selections) and all endpoints will have their paths fixed (e.g. from /user/?selection=crimes to /user/crimes/). 

 

Hopefully that will fix all code-gen issues!

MightyGoober [812478]

You're going to leave it as "v2", and have a version id at the end too?

 
That's kinda ugly to put into stone don't you think?

 

/splent/user/crimes/1 is much better right?

Anything but v2/foo/bar/1

 

Confusing to first time devs of Torn.

Glasnost [1844049]

For both API v1 (and when it comes, v2), can we get a field to indicate whether items are locked for purchase in bazaars? The data isn't available and when building market tools, it frustrates people to visit a bazaar only to find the item can't be purchased, and it is locked at the top of a page as the cheapest.

splent [2088243]

Hey, 

I'm not sure I quite get what you mean. If you're talking about 'user' -> 'bazaar' selection, it has 30s cache to help prevent mug bots, so it could happen that an item is sold, but the API still shows it as "available". So there isn't "locked for purchase" state that I could share.
Bazaar owners do get real-time data with "limited", "full" or "custom" keys though.

Glasnost [1844049]

For both API v1 (and when it comes, v2), can we get a field to indicate whether items are locked for purchase in bazaars? The data isn't available and when building market tools, it frustrates people to visit a bazaar only to find the item can't be purchased, and it is locked at the top of a page as the cheapest.

splent [2088243]

Hey, 

I'm not sure I quite get what you mean. If you're talking about 'user' -> 'bazaar' selection, it has 30s cache to help prevent mug bots, so it could happen that an item is sold, but the API still shows it as "available". So there isn't "locked for purchase" state that I could share.
Bazaar owners do get real-time data with "limited", "full" or "custom" keys though.

Glasnost [1844049]

For example:

https://www.torn.com/bazaar.php?userId=711817#/

 

It has no option to purchase it.

 

 

Manuito [2225097]

Unless I'm mistaken, in v2, this three nullables:

 

      "nullable": "true"

 

should be really be

 

       "nullable": true

 

(no commas):

 

 

            "ItemMarketListingItemStats": {
                "properties": {
                    "damage": {
                        "type": "number",
                        "format": "float",
                        "nullable": "true"
                    },
                    "accuracy": {
                        "type": "number",
                        "format": "float",
                        "nullable": "true"
                    },
                    "armor": {
                        "type": "number",
                        "format": "float",
                        "nullable": "true"
                    }
                },
                "type": "object"
            },

 

 

Otherwise it's causing a parsing error when automating the swagger model creation.

splent [2088243]

Thanks - I've fixed these now I think?

If everything goes as planned, this week I should finish v2 upgrade where requests will also work in this format: "/v2/user/crimes/1/" (or "/v2/user/crimes,timestamp/1/" when requesting multiple selections) and all endpoints will have their paths fixed (e.g. from /user/?selection=crimes to /user/crimes/). 

 

Hopefully that will fix all code-gen issues!

MightyGoober [812478]

You're going to leave it as "v2", and have a version id at the end too?

 
That's kinda ugly to put into stone don't you think?

 

/splent/user/crimes/1 is much better right?

Anything but v2/foo/bar/1

 

Confusing to first time devs of Torn.

splent [2088243]

Looks like this will change a bit after all. After some internal discussion with another developer, we decided the API v2 format to be this:

• /v2/section/selection or 
• /v2/section/{id}/selection

So e.g. "/v2/user/1/bazaar/" or "/v2/user/1/bazaar" or "/v2/user/merits/" or "/v2/user/merits" 

--

Just to clarify, because I'm not sure I 100% understand what you mean with this:

You're going to leave it as "v2", and have a version id at the end too?

That on the end is not a version id, but an id of something (user, faction, company, itemmarket listing etc.), so in Swagger, for new developers, it should look like this:

Base URL: https://api.torn.com/v2
Endpoint: /torn/{id}/subcrimes

I think that shouldn't be confusing as the meaning of "id" is described in Swagger as well? 

MightyGoober [812478]

whoops, gotcha.

 

Even still, the /v2/ prefix on everything is a little ugly IMO, but it's all hidden to the average user, so I guess it's not a big deal.

Glasnost [1844049]

For both API v1 (and when it comes, v2), can we get a field to indicate whether items are locked for purchase in bazaars? The data isn't available and when building market tools, it frustrates people to visit a bazaar only to find the item can't be purchased, and it is locked at the top of a page as the cheapest.

splent [2088243]

Hey, 

I'm not sure I quite get what you mean. If you're talking about 'user' -> 'bazaar' selection, it has 30s cache to help prevent mug bots, so it could happen that an item is sold, but the API still shows it as "available". So there isn't "locked for purchase" state that I could share.
Bazaar owners do get real-time data with "limited", "full" or "custom" keys though.

Glasnost [1844049]

For example:

https://www.torn.com/bazaar.php?userId=711817#/

 

It has no option to purchase it.

 

 

Omanpx [1906686]

That is sort of the idea behind $1 items though, isn't it? So that it's a lottery who can buy them and people go looking through a bunch of bazaars to maybe find something new along their search, sort of a boost to trader advertisements. AFAIK it's locked to certain user IDs (or a range / list of IDs) and determined upon listing the item at $1.

Glasnost [1844049]

For both API v1 (and when it comes, v2), can we get a field to indicate whether items are locked for purchase in bazaars? The data isn't available and when building market tools, it frustrates people to visit a bazaar only to find the item can't be purchased, and it is locked at the top of a page as the cheapest.

splent [2088243]

Hey, 

I'm not sure I quite get what you mean. If you're talking about 'user' -> 'bazaar' selection, it has 30s cache to help prevent mug bots, so it could happen that an item is sold, but the API still shows it as "available". So there isn't "locked for purchase" state that I could share.
Bazaar owners do get real-time data with "limited", "full" or "custom" keys though.

Glasnost [1844049]

For example:

https://www.torn.com/bazaar.php?userId=711817#/

 

It has no option to purchase it.

 

 

Omanpx [1906686]

That is sort of the idea behind $1 items though, isn't it? So that it's a lottery who can buy them and people go looking through a bunch of bazaars to maybe find something new along their search, sort of a boost to trader advertisements. AFAIK it's locked to certain user IDs (or a range / list of IDs) and determined upon listing the item at $1.

splent [2088243]

Are you sure? I'm like 90% sure these are locked for everyone until the "Black Friday" event, when they become purchasable to everyone. 

I just added an item to my bazaar for $1 and it's not purchasable, and I don't have an option to change that either. I'm pretty sure these weren't visible on the old item market either?

I could be wrong though, I never really paid attention to Black Friday sales.

I stand corrected! 

Glasnost [1844049]

For both API v1 (and when it comes, v2), can we get a field to indicate whether items are locked for purchase in bazaars? The data isn't available and when building market tools, it frustrates people to visit a bazaar only to find the item can't be purchased, and it is locked at the top of a page as the cheapest.

splent [2088243]

Hey, 

I'm not sure I quite get what you mean. If you're talking about 'user' -> 'bazaar' selection, it has 30s cache to help prevent mug bots, so it could happen that an item is sold, but the API still shows it as "available". So there isn't "locked for purchase" state that I could share.
Bazaar owners do get real-time data with "limited", "full" or "custom" keys though.

Glasnost [1844049]

For example:

https://www.torn.com/bazaar.php?userId=711817#/

 

It has no option to purchase it.

 

 

Omanpx [1906686]

That is sort of the idea behind $1 items though, isn't it? So that it's a lottery who can buy them and people go looking through a bunch of bazaars to maybe find something new along their search, sort of a boost to trader advertisements. AFAIK it's locked to certain user IDs (or a range / list of IDs) and determined upon listing the item at $1.

splent [2088243]

Are you sure? I'm like 90% sure these are locked for everyone until the "Black Friday" event, when they become purchasable to everyone. 

I just added an item to my bazaar for $1 and it's not purchasable, and I don't have an option to change that either. I'm pretty sure these weren't visible on the old item market either?

I could be wrong though, I never really paid attention to Black Friday sales.

I stand corrected!